Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Project Lombok dependency #9

Merged
merged 9 commits into from
Nov 4, 2021
Merged

Remove Project Lombok dependency #9

merged 9 commits into from
Nov 4, 2021

Conversation

grevend-bosch
Copy link
Contributor

@grevend-bosch grevend-bosch commented Oct 25, 2021

Does not mirror Lombok generation of toString, equals and hashCode!

Signed-off-by: David Greven fixed-term.David.Greven@de.bosch.com

Signed-off-by: David Greven <fixed-term.David.Greven@de.bosch.com>
Signed-off-by: David Greven <fixed-term.David.Greven@de.bosch.com>
Signed-off-by: David Greven <fixed-term.David.Greven@de.bosch.com>
@grevend-bosch grevend-bosch added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 25, 2021
@grevend-bosch grevend-bosch self-assigned this Oct 25, 2021
@grevend-bosch grevend-bosch added this to In Progress in Platform via automation Oct 25, 2021
@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #9 (79dac4f) into master (6e1b975) will increase coverage by 2.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master        #9      +/-   ##
=============================================
+ Coverage     97.72%   100.00%   +2.27%     
- Complexity       17        19       +2     
=============================================
  Files             1         1              
  Lines            44        49       +5     
  Branches          4         4              
=============================================
+ Hits             43        49       +6     
+ Partials          1         0       -1     
Impacted Files Coverage Δ
...ack/mpspdz/integration/MpSpdzIntegrationUtils.java 100.00% <100.00%> (+2.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e1b975...79dac4f. Read the comment docs.

Signed-off-by: David Greven <fixed-term.David.Greven@de.bosch.com>
Signed-off-by: David Greven <fixed-term.David.Greven@de.bosch.com>
Signed-off-by: David Greven <fixed-term.David.Greven@de.bosch.com>
@grevend-bosch
Copy link
Contributor Author

@sbckr Will our publish release flow also work without dependencies (e.g. missing folder)?

@grevend-bosch grevend-bosch linked an issue Oct 25, 2021 that may be closed by this pull request
@grevend-bosch grevend-bosch moved this from In Progress to Blocked in Platform Oct 25, 2021
@grevend-bosch grevend-bosch removed the request for review from strieflin November 2, 2021 13:02
@sbckr
Copy link
Member

sbckr commented Nov 3, 2021

@sbckr Will our publish release flow also work without dependencies (e.g. missing folder)?

@grevend-bosch the Retrieve license obligation resources of the workflow will fail as multiple commands will return an error code and therefore cause the given step to fail. In addition, the Create draft step will have an invalid reference as configuration parameter for artifacts which might cause additional issues.

Signed-off-by: David Greven <fixed-term.David.Greven@de.bosch.com>
Signed-off-by: David Greven <fixed-term.David.Greven@de.bosch.com>
@grevend-bosch
Copy link
Contributor Author

@sbckr Will our publish release flow also work without dependencies (e.g. missing folder)?

@grevend-bosch the Retrieve license obligation resources of the workflow will fail as multiple commands will return an error code and therefore cause the given step to fail. In addition, the Create draft step will have an invalid reference as configuration parameter for artifacts which might cause additional issues.

@sbckr Should be resolved now.

Platform automation moved this from Blocked to Reviewer Approved Nov 4, 2021
Copy link
Member

@sbckr sbckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbckr sbckr merged commit 397e80d into master Nov 4, 2021
Platform automation moved this from Reviewer Approved to Done Nov 4, 2021
@sbckr sbckr deleted the remove-lombok branch November 4, 2021 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
Development

Successfully merging this pull request may close these issues.

Remove Project Lombok dependency
2 participants