-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Project Lombok dependency #9
Conversation
Signed-off-by: David Greven <fixed-term.David.Greven@de.bosch.com>
Signed-off-by: David Greven <fixed-term.David.Greven@de.bosch.com>
Signed-off-by: David Greven <fixed-term.David.Greven@de.bosch.com>
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
=============================================
+ Coverage 97.72% 100.00% +2.27%
- Complexity 17 19 +2
=============================================
Files 1 1
Lines 44 49 +5
Branches 4 4
=============================================
+ Hits 43 49 +6
+ Partials 1 0 -1
Continue to review full report at Codecov.
|
Signed-off-by: David Greven <fixed-term.David.Greven@de.bosch.com>
Signed-off-by: David Greven <fixed-term.David.Greven@de.bosch.com>
Signed-off-by: David Greven <fixed-term.David.Greven@de.bosch.com>
@sbckr Will our publish release flow also work without dependencies (e.g. missing folder)? |
@grevend-bosch the Retrieve license obligation resources of the workflow will fail as multiple commands will return an error code and therefore cause the given step to fail. In addition, the Create draft step will have an invalid reference as configuration parameter for |
Signed-off-by: David Greven <fixed-term.David.Greven@de.bosch.com>
Signed-off-by: David Greven <fixed-term.David.Greven@de.bosch.com>
@sbckr Should be resolved now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Does not mirror Lombok generation of toString, equals and hashCode!
Signed-off-by: David Greven fixed-term.David.Greven@de.bosch.com